Skip to content

Picture in Picture 1.0 #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

rossimo
Copy link
Contributor

@rossimo rossimo commented Jan 4, 2025

Picture in Picture

This plugin allows streaming services to be viewed while in-game.

https://github.com/rossimo/decky-pip

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove assets, backend, defaults and py_modules folders as you do not appear to be making use of them. Please fill out the package.json file so it is not identical to that of the template. Change your license file to include the original plugin template license below your new license at the top. If you are not making use of the python backend at all, please remove main.py as well. Please also remove the root and debug flags from plugin.json, removing the template and root tags as well. In place of those tags add tags that are words or phrases that help users to search for your plugin based on functionality.

@TrainDoctor TrainDoctor added the needsfix An issue/change request needs to be resolved label Jan 12, 2025
@rossimo
Copy link
Contributor Author

rossimo commented Jan 13, 2025

@TrainDoctor Thanks for the review! Changes are in.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for testing.

@TrainDoctor TrainDoctor requested review from a team January 13, 2025 06:24
@TrainDoctor TrainDoctor removed the needsfix An issue/change request needs to be resolved label Jan 13, 2025
@wynn1212
Copy link
Contributor

Testing Report

Currently installed plugins

  • Free Loader - 1.3.0-6f8f352
  • Picture in Picture - 1.0.0-8489d63
  • Pause Games - 1.0.0-b2be59f
  • Decky Terminal - 0.4.1
  • Bluetooth - 2.3.0
  • Emudecky - 1.0.8-cca33c1
  • Game Theme Music - 1.7.0-2d20293
  • ProtonDB Badges - 1.1.0
  • BT Wake Control - 1.1.2
  • PowerTools - 2.0.3
  • Notebook - 0.1.5
  • Decky Recorder - 0.4.1
  • Animation Changer - 1.3.1
  • CSS Loader - 2.1.2
  • Battery Tracker - 0.2.0
  • Wine Cellar - 0.1.6-cf38b52
  • AutoFlatpaks -1.6.7
  • Audio Loader - 1.6.0-5646408
  • NonSteamLaunchers - 1.0.1-2213950
  • SteamGridDB - 1.5.1-loaderv2-f5d753f
  • DeckSettings - 1.3.0-de05be7

Version

  • SteamOS 3.6.20_20241030.1 (Stable)
  • Steam version 1733265492 (Stable)
  • Decky V3.0.5 (Stable)

Major blocking issue

  • none

Minor issue

  • YouTube fullscreen is broken due to YouTube's UI design
    • Anything other than small size will break video layout
    • With smallest size, the video would fit near prefectly, but the scroll bar on the buttom cover the video.
  • If PIP is on and the game is running, then go to any other plugin's full page (e.g. Decky's setting page), the input will become unresponsive (Except for Steam and QAM button). As it turns out all the input has been passthrough into the game.

Version

  • SteamOS 3.6.21_20241212.1 (Beta,Preview)
  • Steam version 1736213535 (Beta)
  • Decky V3.1.2-pre1 (Preview)

Major blocking issue

  • none

Minor issue

  • YouTube fullscreen is broken due to YouTube's UI design
    • Anything other than small size will break video layout
    • With smallest size, the video would fit near prefectly, but the scroll bar on the buttom cover the video.
  • If PIP is on and the game is running, then go to any other plugin's full page (e.g. Decky's setting page), the input will become unresponsive (Except for Steam and QAM button). As it turns out all the input has been passthrough into the game.

Version

  • SteamOS 3.7_20250110.1000 (Main)
  • Steam version 1736213535 (Beta)
  • Decky V3.1.2-pre1 (Preview)

Major blocking issue

  • none

Minor issue

  • YouTube fullscreen is broken due to YouTube's UI design
    • Anything other than small size will break video layout
    • With smallest size, the video would fit near prefectly, but the scroll bar on the buttom cover the video.
  • If PIP is on and the game is running, then go to any other plugin's full page (e.g. Decky's setting page), the input will become unresponsive (Except for Steam and QAM button). As it turns out all the input has been passthrough into the game.

Summary

Yay/nay on to send to the production store or if it requires more testing.

  • Works as intented, although with the minor issue, it's yay for send to production store.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testers approve with non-blocking minor issue noted. Good for production.

@TrainDoctor TrainDoctor merged commit 361db5f into SteamDeckHomebrew:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants