-
Notifications
You must be signed in to change notification settings - Fork 128
added: simple-timer @ 1.0.0 #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@justjoeyuk Please update your testing reports to conform to this template. You need to give more information than what was provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justjoeyuk The image in your plugins.json should be used to show your plugin or a graphic representing what it does, not advertise a website on the plugin store. decktools.xyz is fine in the author field, but please select a different image.
@EMERALD0874 Understood. Promo image has been updated to: https://www.decktools.xyz/simple-timer-promo.jpeg and my testing reports have been updated to conform with the template. |
Approved for deployment to testing store. |
Was having a play with this in the morning and the timer appears to restart if you let the timer expire while the deck is in standby. |
I may be a bit picky on this, but:
|
@ohaiibuzzle thanks for the suggestion, will handle implementation that way - good shout |
@justjoeyuk Please do not check that someone has tested your plugin at the bottom of your PR template until a testing report has been submitted with the proper format. I've had to uncheck that for you twice. |
Testing ReportVersionsDecky: v3.1.2-pre1 SummaryMajor blocking issuesNone Minor issuesNone Currently installed plugins
Yay/nay on to send to the production store or if it requires more testing.Looks good to me, although I agree that the formatting of the time remaining could use some tweaking |
I have updated the plugin to v1.0.0 with changes proposed for sleep management.
|
@Tormak9970 just want you to confirm no blocking issues with the latest version whenever possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this briefly on my Deck (with Stable SteamOS) and had no blocking issues with the latest version. Also checked the latest features and they seem to work as intended. Checked the code and it also looks good. Considering this good to go!
simple-timer
A minimal plugin designed for simplicity and ease of use.
Plugin Repo
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing