Fix and improve plugin thoroughly (to 3.8.2) #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mr.Silence
Signed-off-by: Mr.Silence
…7.3. Signed-off-by: Mr.Silence
…ay at the top. Updated configuration files. Signed-off-by: Mr.Silence
…he nomination in the chat. This should be corrected now. Signed-off-by: Mr.Silence
Signed-off-by: Mr.Silence
Signed-off-by: Mr.Silence
Signed-off-by: Mr.Silence <Silenci0@users.noreply.github.com>
Signed-off-by: Mr.Silence <Silenci0@users.noreply.github.com>
Signed-off-by: Mr.Silence <Silenci0@users.noreply.github.com>
Signed-off-by: Mr.Silence <Silenci0@users.noreply.github.com>
Signed-off-by: Mr.Silence <Silenci0@users.noreply.github.com>
- Fix lists cleanup at OnConfigsExecuted deleting vital data loaded at OnMapStart (when the former is called later), breaking the whole display
- Specialize default last countdown notification into a more significative translation ("Map Vote Started")
- Allow multiple print destinations for the timed notifications by increasing the notification type buffers
When "plain" map votes were created in response to map groups getting excluded (as a fallback), vote results failed because they were handled with the original Tier/Group callback, rather than "plain" maps one. When the fallback happens, the results handler's type is now replaced with the correct one.
- Keep "Vote pending" display instead of a map while an end vote holds - Make Random Cycle select a provisional next map (via SetNextMap, natively, to prevent affecting other modules) at map start anyway when the mode CVar is set to compute it at map end, keeping the initial one if still valid by that time. This way, nextmap display is more likely to match the final map (when "Pending vote" isn't shown).
- Localize the "Stop Adding Maps" admin menu voting generation option - Thoroughly enhance and fix Spanish phrases, also fitting truncated menu items - Improve few syntax/stylistic unimportant parts of all languages - Shorten end vote warning phrase to fit at Hint Text window in some games
Adrianilloo
changed the title
When no module that implements UMC_OnDetermineMapExclude was present, all maps from the full mapcycle were included in the user lists regardless of some/all not existing in the filtered mapcycle (e.g. RTV second voting stage for tiered votes)
Adrianilloo
changed the title
|
Is TF2 workshop map support in this fork? |
Owner
|
Apologies for the delay, for whatever reason I never received a GitHub notification. This is fantastic work, I'm happy to accept this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of a really caring, considerable, durable and revised work that started off with the idea of merging the Silenci0's fork I found out from someone's AM Discord message.
Since then, I also fixed, polished and enhanced the plugin according to several middle-to-high issues I found out after the addition of this plugin to my HL2: DM server, which you can carefully check with each commit message involved, with enough level of detail.
Important things to consider:
SM 1.11 compiler currently has a bug regarding dynamic array generation syntax that affects the plugin if compiled under that version. This could be easily solved by briefly replacing a certain-> Fixed recently under SP version 1.11.0.6863floatarray declaration, but I prefer to wait as the SM team should publish a new fixed release soon.