Removed valid_before and valid_after fields from transaction rela…

…ted response.
StellarCN · Nov 17, 2024 · c8e646a · c8e646a
1 parent a59fea7
commit c8e646a
Show file tree

Hide file tree

Showing 5 changed files with 53 additions and 193 deletions.
diff --git a/stellar_model/model/horizon/transaction.py b/stellar_model/model/horizon/transaction.py
@@ -161,16 +161,6 @@ class Transaction(BaseModel):
     signatures: List[str] = Field(
         description="An array of signatures used to sign this transaction."
     )
-    valid_after: Optional[datetime] = Field(
-        description="The datetime after which a transaction is valid. This field is deprecated in lieu "
-        "of `preconditions.time_bounds.min_time` and will be removed in Horizon v3.",
-        default=None,
-    )
-    valid_before: Optional[datetime] = Field(
-        description="The datetime before which a transaction is valid. This field is deprecated in lieu "
-        "of `preconditions.time_bounds.max_time` and will be removed in Horizon v3.",
-        default=None,
-    )
     preconditions: Optional[TransactionPreconditions] = Field(
         description="A set of transaction preconditions affecting its validity.",
         default=None,

diff --git a/tests/model/horizon/test_transaction.py b/tests/model/horizon/test_transaction.py
@@ -59,14 +59,6 @@ def test_transaction_valid(self):
             parsed_data.signatures[0],
             "zktIGIVFAq0VhE+k1pvBW68iFlJVENpqN/QrNhqomaBpcCUVpM5jJhzXVi7FQzUXOXVVPhQRsjbYG87/wfNSBA==",
         )
-        self.assertEqual(
-            parsed_data.valid_after,
-            datetime.datetime(1970, 1, 1, 0, 0, tzinfo=datetime.timezone.utc),
-        )
-        self.assertEqual(
-            parsed_data.valid_before,
-            datetime.datetime(2022, 5, 6, 5, 29, 45, tzinfo=datetime.timezone.utc),
-        )
         self.assertEqual(
             parsed_data.preconditions.timebounds.min_time,
             datetime.datetime(1970, 1, 1, 0, 0, tzinfo=datetime.timezone.utc),
@@ -150,14 +142,6 @@ def test_transaction_fee_bump_valid(self):
             parsed_data.signatures[0],
             "KbfbHT6jbk7gCOyyKZ+cyGQPnNoTAHy3lZgGqbrPkNWE8ekJSnicNScamUQYzngXkyd2ekTdmQxTaPkEHleTBQ==",
         )
-        self.assertEqual(
-            parsed_data.valid_after,
-            datetime.datetime(2021, 4, 24, 1, 52, 57, tzinfo=datetime.timezone.utc),
-        )
-        self.assertEqual(
-            parsed_data.valid_before,
-            datetime.datetime(2021, 4, 24, 1, 57, 52, tzinfo=datetime.timezone.utc),
-        )
         self.assertEqual(
             parsed_data.fee_bump_transaction.hash,
             "ac8cf91a1c0559091ba26573c0966191ae81466d5df4931af302f135d99c0d72",

diff --git a/tests/resources/model/horizon/transaction.json b/tests/resources/model/horizon/transaction.json
@@ -47,8 +47,6 @@
   "signatures": [
     "zktIGIVFAq0VhE+k1pvBW68iFlJVENpqN/QrNhqomaBpcCUVpM5jJhzXVi7FQzUXOXVVPhQRsjbYG87/wfNSBA=="
   ],
-  "valid_after": "1970-01-01T00:00:00Z",
-  "valid_before": "2022-05-06T05:29:45Z",
   "preconditions": {
     "timebounds": {
       "min_time": "1970-01-01T00:00:00Z",

diff --git a/tests/resources/model/horizon/transaction_fee_bump.json b/tests/resources/model/horizon/transaction_fee_bump.json
@@ -49,8 +49,6 @@
   "signatures": [
     "KbfbHT6jbk7gCOyyKZ+cyGQPnNoTAHy3lZgGqbrPkNWE8ekJSnicNScamUQYzngXkyd2ekTdmQxTaPkEHleTBQ=="
   ],
-  "valid_after": "2021-04-24T01:52:57Z",
-  "valid_before": "2021-04-24T01:57:52Z",
   "fee_bump_transaction": {
     "hash": "ac8cf91a1c0559091ba26573c0966191ae81466d5df4931af302f135d99c0d72",
     "signatures": [