Add bulk add/remove/read methods using spans. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the minimum .NET requirement to .NET Standard 2.1.
I'm hesitant to add CopyFromBackToSpan because it's not clear if it would be intuitive for it to copy to the end or the beginning of the destination span.
|
I love the span APIs but I can't take the netstandard bump. Can you change this PR to multitarget instead? |
|
Done, I think (somewhat new to C# outside of Unity) |
|
Ping. Sorry for piling on more changes afterwards. Should be all done now. |
|
^ or so I thought 🤦♂️ |
|
Note to self: compare this API with dotnet/runtime#1530 |
|
.NET 8.0 just got span overloads for https://devblogs.microsoft.com/dotnet/performance-improvements-in-net-8/ |
|
Also should include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(ReadOnlySpan<T> span)and(IEnumerable<T> collection)would be ambiguous given an array.