Query::Compound - Conditionally quote search keyword#24
Open
bwoodmansee wants to merge 2 commits intoStevenJL:masterfrom
Open
Query::Compound - Conditionally quote search keyword#24bwoodmansee wants to merge 2 commits intoStevenJL:masterfrom
bwoodmansee wants to merge 2 commits intoStevenJL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the search term is provided in a hash, but the keyword itself is actually not complex the quoting will yield incorrect results
For example, in order to match all documents it is necessary to use a
matchallsearch query and apply theq.parser=structuredquery param. It would be nice to do this as a Compound query, to take advantage of theq.parserparam being appended, however, with the way things are currently quoted, it's not possible.With this fix, you can do
search.search({q: 'matchall'})to perform a search that matches all documents