Add formulas for bispectrum in fourier.py #640
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteobachetti
force-pushed
the
add_bispectrum_from_iterable
branch
from
b596182 to
21e8525
Compare
|
Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-02-24 10:45:49 UTC |
Codecov Report
@@ Coverage Diff @@
## main #640 +/- ##
==========================================
- Coverage 97.21% 96.75% -0.47%
==========================================
Files 41 41
Lines 7535 7576 +41
==========================================
+ Hits 7325 7330 +5
- Misses 210 246 +36
Continue to review full report at Codecov.
|
matteobachetti
force-pushed
the
add_bispectrum_from_iterable
branch
from
21e8525 to
9bad0b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for the 1.0 release.
I had drafted these functions to work on my time series analysis classes, and Issue #639 was a good excuse to start thinking about using them in Stingray :)