Skip to content

Conversation

@Sauravroy34
Copy link
Contributor

@Sauravroy34 Sauravroy34 commented Mar 20, 2025

This PR adds method to smoothen light curves using Poission regressor with spline transformation
closes #905

@Sauravroy34
Copy link
Contributor Author

Sauravroy34 commented Mar 20, 2025

Updated after using poission regressor

smothen_light_curve

Copy link
Member

@matteobachetti matteobachetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sauravroy34, thanks for your contribution.

A couple of comments:

  1. Please take a look at the contribution guidelines: https://docs.stingray.science/en/stable/contributing.html#coding-guidelines. In particular:
    a) We need tests for all functions, and for all lines of code. Tests should be as precise as possible, e.g. testing an expected output, not just that the function executes. Also, Exceptions and warnings should be tested.
    b) Check the style guide, black is very helpful for most of the requirements.

  2. The methods you are listing now assume Gaussian, or at least symmetric, statistical distributions for the counts arrays. These will probably fail for low-countrate data. Among smoothing methods, since light curves are usually Poisson-distributed, it would be good to add a method specific to Poisson-distributed data. Do you have any good one in mind?

@Sauravroy34
Copy link
Contributor Author

i wil try to modiify this code using sckit learn poissonregressor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Method to smoothen a light curve

2 participants