setup.py python package #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IliaFeldgun
force-pushed
the
ilia/package
branch
2 times, most recently
from
d8191b7
to
37a36d1
Compare
PEP-440 versioning with git cli Readme dev-requirements.txt Lint for python3 (incomplete)
IliaFeldgun
force-pushed
the
ilia/package
branch
from
37a36d1
to
1ec72f8
Compare
IliaFeldgun
requested review from
roeigo-stratoscale,
tomerschwartz24,
Harelfel and
simba1997
…uirements.txt Lint for python3 (incomplete)
roeigo-stratoscale
approved these changes
Dec 26, 2023
setup.py
Outdated
| def version(): | ||
| git_describe_cmd = ["git", "describe", "--tags", "HEAD"] | ||
| git_head_tag = subprocess.check_output(git_describe_cmd).strip().decode("utf-8") | ||
| python_version = git_head_tag |
| return python_version | ||
|
|
||
|
|
||
| with open("README.md", "r") as fh: |
There was a problem hiding this comment.
fh to something more meaningful for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as we have a single tag in the repo, we have dynamic versioning