Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DKI/convert_to_vcf #21

Merged
merged 2 commits into from
May 27, 2024
Merged

DKI/convert_to_vcf #21

merged 2 commits into from
May 27, 2024

Conversation

Strexas
Copy link
Owner

@Strexas Strexas commented May 13, 2024

No description provided.

@Strexas Strexas requested a review from nojux-official May 13, 2024 16:03
@Strexas Strexas self-assigned this May 13, 2024
@Strexas Strexas marked this pull request as ready for review May 25, 2024 09:45
nojux-official
nojux-official reviewed May 26, 2024
View reviewed changes
Copy link
Collaborator

@nojux-official nojux-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function works. However, I've noticed some warnings about skipped variants in the pipeline notebook. Is that ok?

@Strexas Strexas merged commit 7d71f6c into main May 27, 2024
6 checks passed
@Strexas Strexas deleted the DKI/convert_to_vcf branch May 27, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojux-official nojux-official nojux-official left review comments

Assignees

@Strexas Strexas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strexas @nojux-official