MDE/PKFE-19 #49
MDE/PKFE-19 #49
Conversation
…y field implemented with a button press
…ming and deletion
| Import... | ||
| </MenuItem>, | ||
| <Divider key='divider-import' /> | ||
| ); |
There was a problem hiding this comment.
if(item.fileType === undefined) and if(item.fileType === FileTypes.FOLDER || item.fileType === undefined) statements seem to do the same thing
There was a problem hiding this comment.
Fixed with new logic
|
|
||
| if (input.length > 50) { | ||
| return 'Input must be less than 50 characters'; | ||
| } |
There was a problem hiding this comment.
We should also validate for forbidden file name characters or forbidden combinations
There was a problem hiding this comment.
Added checks:
- contains
null,/,*,?,[,] - cannot be
.or.. - cannot start or end with
.
There was a problem hiding this comment.
It will work for now, but more character checks should be added in the future
There was a problem hiding this comment.
Created new story in backlog: PKFE-43
There was a problem hiding this comment.
Some problems mentioned in comments on code.
In addition, I don't think a user should be able to change the file type while naming or renaming, or the file type should be seperate from the file name with maybe a dropdown menu. Non-tech savy users could name the file wrong which would cause problems, especially when exporting.
| if (input.length > 50) { | ||
| return 'Input must be less than 50 characters'; | ||
| } | ||
|
|
There was a problem hiding this comment.
We also need to validate if a file with specified name already exists
There was a problem hiding this comment.
Updated workspaceContextProvider.tsx to store file hierarchy and it can be accessed anywhere. New function in utils/helpers.ts provides ability to search for specific file. Added check for existing file while renaming or creating new file. Also added functionality to specify files' extension and removed the ability to define your own extension.
There was a problem hiding this comment.
Great work on the extensions! I just found one more small problem, it doesn't check for cases, I was able to create "A.csv" and "a.csv", it should be able to be solved by temporarily converting file names to lower-cases before checking if they exist.
There was a problem hiding this comment.
Updated helpers.tsx: doesFileExist function. Fixed textfield 'jumping' during error.
…ks and removed ability to specify custom file extensions
…d using centrilized file hierarchy context
| } | ||
|
|
||
| if (/[*?[\]]/.test(input)) { | ||
| return 'Input contains forbidden glob characters (*, ?, [, ])'; |
There was a problem hiding this comment.
We can remove the 'glob' word because I don't think many people would know it's meaning, "...forbidden characters..." should be enough
There was a problem hiding this comment.
Removed!
Initial
Requested Changes 2024-08-30
Requested Changes 2024-09-01