Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JTE/PKFE-42 #52

Merged
merged 5 commits into from
Sep 2, 2024
Merged

JTE/PKFE-42 #52

merged 5 commits into from
Sep 2, 2024

Conversation

justinnas
Copy link
Collaborator

  • Moved editor toolbar groups into seperate files;
  • Moved BaseLayout into routes;
  • Moved Sidebar to a seperate file;
  • Made Sidebar icons clickable;
  • Made it so the icons would be highlighted based on page being visited;
  • Fixed other minor errors.

@justinnas justinnas added the enhancement New feature or request label Sep 2, 2024
@justinnas justinnas self-assigned this Sep 2, 2024
mantvydasdeltuva
mantvydasdeltuva requested changes Sep 2, 2024
View reviewed changes
app/front-end/src/components/buttons/IconTitleButton.tsx
@@ -8,6 +8,7 @@ interface Props {
height?: string;
borderRadius?: string;
onClick?: () => void;
isActive?: boolean;
Copy link
Collaborator

@mantvydasdeltuva mantvydasdeltuva Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add disabled for unusable buttons like macros to not be available (disabled)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

app/front-end/src/components/layouts/baseLayout.tsx Outdated
import { SettingsDialog, ShortcutsDialog } from '@/components/dialogs';
import { Sidebar } from '@/components/sidebar/sidebar';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add index.ts to remove redundancy in pathing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

mantvydasdeltuva
mantvydasdeltuva approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@mantvydasdeltuva mantvydasdeltuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@justinnas justinnas merged commit f55201a into main Sep 2, 2024
0 of 3 checks passed
@justinnas justinnas deleted the JTE/PKFE-42 branch September 2, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantvydasdeltuva mantvydasdeltuva mantvydasdeltuva approved these changes

Assignees

@justinnas justinnas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinnas @mantvydasdeltuva