MDE/PKFE-30 #60
Merged
MDE/PKFE-30 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinnas
reviewed
Sep 11, 2024
| CONSOLE_FEEDBACK_EVENT, | ||
| { | ||
| "type": "errr", | ||
| "message": f"FileNotFoundError: {e} while SpliceAI applying algorithm " |
There was a problem hiding this comment.
while applying SpliceAI algorithm*
justinnas
reviewed
Sep 11, 2024
| CONSOLE_FEEDBACK_EVENT, | ||
| { | ||
| "type": "errr", | ||
| "message": f"PermissionError: {e} while SpliceAI applying algorithm " |
There was a problem hiding this comment.
while applying SpliceAI algorithm*
justinnas
reviewed
Sep 11, 2024
| ) | ||
| return jsonify({"error": "An internal error occurred"}), 500 | ||
|
|
||
| return jsonify({"message": "LOVD data downloaded successful"}), 200 |
justinnas
reviewed
Sep 11, 2024
| ) | ||
| return jsonify({"error": "An internal error occurred"}), 500 | ||
|
|
||
| return jsonify({"message": "CliVar data downloaded successful"}), 200 |
justinnas
reviewed
Sep 11, 2024
| ) | ||
| return jsonify({"error": "An internal error occurred"}), 500 | ||
|
|
||
| return jsonify({"message": "gnomAD data downloaded successful"}), 200 |
justinnas
reviewed
Sep 11, 2024
| String(now.getHours()).padStart(2, '0') + | ||
| ':' + | ||
| String(now.getMinutes()).padStart(2, '0') + | ||
| ':' + |
There was a problem hiding this comment.
':' is an illegal file name character in Windows. Would be better and safer to just seperate everything with '-', '_' or '.'
justinnas
reviewed
Sep 11, 2024
| { | ||
| "type": "info", | ||
| "message": f"Applying SpliceAI algorithm to '{relative_path}' with " | ||
| + f"override: `{override}'...", |
There was a problem hiding this comment.
` {override}'
There are different quotation marks. Should be '
There was a problem hiding this comment.
It also applies to other places where similiar text line was copy-pasted
justinnas
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial 2024-09-11
Requested changes 2024-09-12