Changes/gh 8 #36
Draft
Changes/gh 8 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Butz <thomas.butz@optitool.de>
…lation with "network=lcn". (graphhopper#2693) See https://wiki.openstreetmap.org/wiki/DE:Tag:lcn%3Dyes
This reverts commit 03e64da.
One example is vehicle = agricultural;forestry Now we block also such combinations for bikes.
* removed legacy parameters * fixed error message
…graphhopper#2702)" This reverts commit ef2937f.
… tests of the model, fixes graphhopper#2820
…es missing symbols in terminals
* try jdk 20 * try again
…graphhopper#2828) * Process callables in batches to save memory * changelog * Do not re-use Executorservice
* first implementation which is validated with unit tests no focus on performance, code beauty or documentation. used for validation and comparison with some real world test areas * overwrite previous averaging algorithm, added unit tests and made window size configurable * explain unit test * incorporate pr feedback from otbutz * use IntDoubleHashMap to avoid object unboxing * extended contributor list * pr feedback: rename config to be more consistent * pr feedback: code formatting * pr feedback: having a dedicated class for each implementation and tests
…#2832) * initial workaround for graphhopper#2829 * use enum
* previously we got an error when we tried to call getEdgeIteratorState with edge IDs running up to QueryGraph#getEdges()
* initial version to include subdivision in Country enum * minor fix * use correct PR * GHUtility cleanup * allow country comparison via getAlpha3 method * minor fixes * clarify iso codes with the help of wikipedia * use alpha2 for custom model to make it more consistent * minor fixes * try separate state instead of country extension * minor enhancement * use complete use for getStateCode * fix * use getter instead of create * remove TODO * for now this method is used only once, so avoid overhead * shorter
* Fix interchanged parameter names in bit util * removed BitUtilBig * cleanup --------- Co-authored-by: Peter <graphhopper@gmx.de>
* initial version * less output * maxspeed tag vs max_speed name * less logging * use urbanDensity in replaceFunction and explicitly set maxspeed only if UNSET_SPEED * added tests * replace CountryRule.getMaxSpeed with LegalDefaultSpeeds lib * tricky. thinking... * lane support * surface support * residential roads have the same limits in Germany * do not forget the reverse speed * use same version as osm-legal-default-speeds-jvm * something is strange with dropwizard tests as they require an explicit dependency on kotlin-stdlib (not kotlin-stdlib-jdk8) * force okhttp and osm-legal-default-speeds-jvm to use both more recent but same kotlin 1.8.0 * use more recent okio with recommended kotlin 1.6.20; seems to work for osm-legal-default-speeds-jvm too * make createWeightingParameters public * separate storage and parser for default max speed and only combine this after import with the maxspeed tag from OSM * separate close * default speed library does not support maxspeed:forward and :backward tags * test regarding living_street is now useless at that level * comment * fix problematic forward/backward case * store osm max_speed and temporarily the default urban+rural from library to improve max_speed afterwards * reduce overhead a bit and force type * grow array on get too * storage: we need a tiny offset * okhttp 4.11.0 has cleaner deps * reduce tag count and cache speeds to reduce overhead, see westnordost/osm-legal-default-speeds#7 * configure preliminary GHDirectory * added maxweight * avoid default-maxspeed library while OSM parsing * Revert "avoid default-maxspeed library while OSM parsing" This reverts commit 8b07594. * fix setup to use the same GHDirectory instance to avoid problems with missing directory etc * consider walk as 6kmh * don't interpret country-dependent speeds in stringToKmh * call computeIfAbsent for cache; convert maxspeed into kmh before import; fix test for stringToKmh * fix comment * added description to config * add max_speed_estimated boolean encoded value * use speedlib v1.3 * use statecode to feed speedlib * updated legal_default_speeds.json * residential should not be ignored but treated as tertiary, graphhopper#2832 * comment
Fix compilation and tests
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bear in mind
[RSPS-XX]: DescriptionJira Ticket
Example-ticket-to-be-replaced
Implementation details
Type a brief description of the implementation details and/or sensitive parts of the code that can be affected by this change
Examples
Write some examples if you consider them necessary to contextualize better your development done.
Testing
If necessary add description on what is tested locally and all the types of tests you added.