Skip to content

refactor(tests): update mocks, add tests and improve code quality #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cagataycode wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(tests): update mocks, add tests and improve code quality #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 28 additions & 58 deletions src/auth/auth.controller.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/* eslint-disable @typescript-eslint/no-unsafe-return */
/* eslint-disable @typescript-eslint/unbound-method */
/* eslint-disable @typescript-eslint/no-unsafe-argument */
import { Test, TestingModule } from '@nestjs/testing';
import { AuthController } from './auth.controller';
import { AuthService } from './auth.service';
Expand Down Expand Up @@ -38,7 +37,7 @@ describe('AuthController', () => {
RP_NAME: 'Motimate',
RP_ORIGIN: 'https://motiemate.com',
};
return envVariables[key];
return envVariables[key] as unknown;
}),
};

Expand Down Expand Up @@ -149,28 +148,21 @@ describe('AuthController', () => {
});
describe('changePassword', () => {
it('should change password successfully', async () => {
jest.spyOn(
controller['authService'],
'changePassword',
).mockResolvedValue(undefined);
const spy = jest
.spyOn(controller['authService'], 'changePassword')
.mockResolvedValue(undefined);
const userId = 1;
const newPassword = 'newPassword123';

const result = await controller.changePassword(userId, newPassword);

expect(
controller['authService'].changePassword,
).toHaveBeenCalledWith(userId, newPassword);
expect(spy).toHaveBeenCalledWith(userId, newPassword);
expect(result).toEqual({
message: 'Password changed successfully',
});
});

it('should throw BadRequestException when changePassword fails', async () => {
jest.spyOn(
controller['authService'],
'changePassword',
).mockRejectedValue(new Error('Failed'));
const userId = 1;
const newPassword = 'newPassword123';

Expand All @@ -185,26 +177,19 @@ describe('AuthController', () => {
challenge: 'test-challenge',
user: { id: 'user-id' },
} as unknown as jest.Mocked<Challenge>;
jest.spyOn(
controller['authService'],
'generateRegistrationOptions',
).mockResolvedValue(mockChallenge);
const spy = jest
.spyOn(controller['authService'], 'generateRegistrationOptions')
.mockResolvedValue(mockChallenge);
const userId = 'user-id';

const result = await controller.webauthnRegister(userId);

expect(
controller['authService'].generateRegistrationOptions,
).toHaveBeenCalledWith(userId);
expect(spy).toHaveBeenCalledWith(userId);
expect(result).toBeInstanceOf(ChallengeDTO);
expect(result).toEqual(new ChallengeDTO(mockChallenge));
});

it('should throw BadRequestException when generateRegistrationOptions fails', async () => {
jest.spyOn(
controller['authService'],
'generateRegistrationOptions',
).mockRejectedValue(new Error('Failed'));
const userId = 'user-id';

await expect(controller.webauthnRegister(userId)).rejects.toThrow(
Expand All @@ -218,31 +203,24 @@ describe('AuthController', () => {
id: 'credential-id',
} as RegistrationResponseJSON;
const mockVerification = { verified: true };
jest.spyOn(
controller['authService'],
'verifyRegistrationResponse',
).mockResolvedValue(mockVerification);
const spy = jest
.spyOn(controller['authService'], 'verifyRegistrationResponse')
.mockResolvedValue(mockVerification);
const userId = 'user-id';

const result = await controller.webauthnRegisterVerify(
mockResponse,
userId,
);

expect(
controller['authService'].verifyRegistrationResponse,
).toHaveBeenCalledWith(mockResponse, userId);
expect(spy).toHaveBeenCalledWith(mockResponse, userId);
expect(result).toEqual({ verification: mockVerification });
});

it('should throw UnauthorizedException when verifyRegistrationResponse fails', async () => {
const mockResponse = {
id: 'credential-id',
} as RegistrationResponseJSON;
jest.spyOn(
controller['authService'],
'verifyRegistrationResponse',
).mockRejectedValue(new Error('Failed'));
const userId = 'user-id';

await expect(
Expand All @@ -255,26 +233,22 @@ describe('AuthController', () => {
const mockChallenge = {
challenge: 'test-challenge',
} as unknown as jest.Mocked<Challenge>;
jest.spyOn(
controller['authService'],
'generateAuthenticationOptions',
).mockResolvedValue(mockChallenge);
const spy = jest
.spyOn(
controller['authService'],
'generateAuthenticationOptions',
)
.mockResolvedValue(mockChallenge);
const userId = 'user-id';

const result = await controller.webauthnAuthenticate(userId);

expect(
controller['authService'].generateAuthenticationOptions,
).toHaveBeenCalledWith(userId);
expect(spy).toHaveBeenCalledWith(userId);
expect(result).toBeInstanceOf(ChallengeDTO);
expect(result).toEqual(new ChallengeDTO(mockChallenge));
});

it('should throw BadRequestException when generateAuthenticationOptions fails', async () => {
jest.spyOn(
controller['authService'],
'generateAuthenticationOptions',
).mockRejectedValue(new Error('Failed'));
const userId = 'user-id';

await expect(
Expand All @@ -290,31 +264,27 @@ describe('AuthController', () => {
const mockVerification = {
verified: true,
} as VerifiedAuthenticationResponse;
jest.spyOn(
controller['authService'],
'verifyAuthenticationResponse',
).mockResolvedValue(mockVerification);
const spy = jest
.spyOn(
controller['authService'],
'verifyAuthenticationResponse',
)
.mockResolvedValue(mockVerification);
const userId = 'user-id';

const result = await controller.webauthnAuthenticateVerify(
mockResponse,
userId,
);

expect(
controller['authService'].verifyAuthenticationResponse,
).toHaveBeenCalledWith(mockResponse, userId);
expect(spy).toHaveBeenCalledWith(mockResponse, userId);
expect(result).toEqual({ verification: mockVerification });
});

it('should throw UnauthorizedException when verifyAuthenticationResponse fails', async () => {
const mockResponse = {
id: 'credential-id',
} as AuthenticationResponseJSON;
jest.spyOn(
controller['authService'],
'verifyAuthenticationResponse',
).mockRejectedValue(new Error('Failed'));
const userId = 'user-id';

await expect(
Expand Down
Loading