Fix headless RenderPlay not tracking frames for TakeSnapshot#685
Open
habibrehmansg wants to merge 4 commits intoSuRGeoNix:masterfrom
Open
Fix headless RenderPlay not tracking frames for TakeSnapshot#685habibrehmansg wants to merge 4 commits intoSuRGeoNix:masterfrom
habibrehmansg wants to merge 4 commits intoSuRGeoNix:masterfrom
Conversation
In v3.10.2, RenderPlay returns early without calling Frames.SetRendererFrame when SwapChain.CanPresent is false. This breaks TakeSnapshot for headless/offscreen consumers that extract frames without a visible window. In v3.9.7, RenderPlay always set LastFrame regardless of canRenderPresent. Restore that behavior so TakeSnapshot can access the current frame even without a SwapChain. The SetRendererFrame call is wrapped in lockRenderLoops to synchronize with TakeSnapshot, preventing use-after-dispose of GPU frame resources. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
habibrehmansg
force-pushed
the
fix/headless-renderer-frame
branch
from
61f9ea4 to
a58449d
Compare
Author
|
Also checking if there exists a different way to grab frames without a visible window? |
When the swap chain cannot present (headless), apply VP requests immediately instead of queuing them: set vpRequestsIn, clear Resize, and call D3ProcessRequests() or FLProcessRequests() depending on the VideoProcessor. Also move VP request processing into the lockRenderLoops section of Present so queued requests are handled under the same lock before calling Frames.SetRendererFrame(frame), preserving synchronization with TakeSnapshot and matching prior behavior.
Clear the VPRequestType.Resize flag before processing video-processor requests and add a lock around headless (CanPresent == false) VP request processing. This prevents resize requests from being handled in these paths and serializes access to vpRequestsIn to avoid race conditions when processing D3D11 or FL video processor requests.
Owner
|
I will need to revisit this as I don't feel confident for the approach. My understanding is that for example when the window is minimized you still want to be able to take the snapshot of the latest/current frame. That will be disabled by Resize (in SwapChain.cs) with this: CanPresent = controlWidth > 0 && controlHeight > 0;Your current solution creates a performance issue when you don't care for snapshots and your window is minimized. |
Author
|
Ok. If it helps, the use case that led me here was headless playback and grabbing frames for USB panel displays. |
Author
|
Would having a config like player.Config.Video.SnapshotAlways (default false) help alleviate your concern? |
SuRGeoNix
added a commit
that referenced
this pull request
Mar 18, 2026
- Config.Player: Introduces SnapshotAlways to allow off-screen snapshots - Renderer: Adds support for off-screen snapshots
Owner
|
@habibrehmansg can you check my commit and let me know if that satisfies your requirement? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v3.10.2, RenderPlay returns early without calling Frames.SetRendererFrame when SwapChain.CanPresent is false. This breaks TakeSnapshot for headless/offscreen consumers that extract frames without a visible window.
In v3.9.7, RenderPlay always set LastFrame regardless of canRenderPresent. Restore that behavior so TakeSnapshot can access the current frame even without a SwapChain.