Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move credit union under financial type #374

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

kamilxdomo
Copy link

No description provided.

@kamilxdomo kamilxdomo linked an issue Dec 5, 2024 that may be closed by this pull request
@muratabur
Copy link
Contributor

@kamilxdomo what is the rationale behind this. I believe it was omitted from financial based on the list in the documentation for financial but if you have other evidence, then it might need to be included.

Thanks

@kamilxdomo
Copy link
Author

@muratabur James has kindly provided an explanation. As credit unions take deposits and lend money, they meet the definition of financial as described in CRR Article 411. However, contradictorily, NSFR classifies credit unions as non-financial institutions as per CRR Article 428am and listed in the return

Therefore, we are moving credit unions to be a child of financial as this is generally the accepted approach across all returns except NSFR and then change NSFR in isolation to ensure it is treated as non-financial in this return only

@muratabur
Copy link
Contributor

alright, then we need to update the financial enum definition accordingly with that explanation above and we should be good to go

@kamilxdomo
Copy link
Author

@muratabur this should be ready now :)

@kamilxdomo kamilxdomo self-assigned this Dec 13, 2024
@kamilxdomo
Copy link
Author

can we merge this one please @muratabur ?

@muratabur muratabur merged commit 2e37c1d into master Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

credit union child of financial
2 participants