[Feature:RainbowGrades] Adding hover text to bad status cells #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziesski
reviewed
Jul 2, 2024
Co-authored-by: Jaeseok Kang <123261952+ziesski@users.noreply.github.com>
ziesski
requested changes
Jul 4, 2024
table.cpp
Outdated
| } | ||
|
|
||
|
|
||
|
|
||
|
|
table.cpp
Outdated
Comment on lines
97
to
106
| if (event == "Extension" && reason != "") { | ||
| extension = true; | ||
| inquiry = bad_status = override = version_conflict = cancelled = false; | ||
| hoverText = "class=\"hoverable-cell\" data-hover-text=\"" + userName + " received a " + std::to_string(daysExtended) + " day extension due to " + reason + " on " + gID + "\" "; | ||
| } else if (event == "Bad") { | ||
| bad_status = true; | ||
| override = inquiry = extension = version_conflict = cancelled = false; | ||
| hoverText = "class=\"hoverable-cell\" data-hover-text=\"" + userName + " received a bad status on " + gID + "\" "; | ||
| } | ||
|
|
There was a problem hiding this comment.
Is there a reason you are adding this in a separate if statement? Right below this code snippet we have existing if statements that are identical to your addition. I would say it is better to put it in there instead of duplicating the code.
ziesski
requested changes
Jul 8, 2024
table.cpp
Outdated
| hoverText = "class=\"hoverable-cell\" data-hover-text=\""+userName+" received a "+std::to_string(daysExtended)+" day extension without specified reason on "+gID+"\" "; | ||
| } | ||
| if (event == "Extension" && reason != "") { | ||
| hoverText = "class=\"hoverable-cell\" data-hover-text=\"" + userName + " received a " + std::to_string(daysExtended) + " day extension due to " + reason + " on " + gID + "\" "; |
There was a problem hiding this comment.
What I was suggesting is to move the hoverText inside the if statement below, which is line 109
ziesski
requested changes
Jul 10, 2024
Co-authored-by: Jaeseok Kang <123261952+ziesski@users.noreply.github.com>
bmcutler
requested changes
Jul 12, 2024
table.cpp
Outdated
| @@ -109,6 +102,9 @@ TableCell::TableCell(float d, const std::string& c, int precision, const std::st | |||
| } else if (event == "Extension"){ | |||
| extension = true; | |||
| inquiry = bad_status = override = version_conflict = cancelled = false; | |||
| if (reason != ""){ | |||
| hoverText = "class=\"hoverable-cell\" data-hover-text=\"" + userName + " received a " + std::to_string(daysExtended) + " day extension due to " + reason + " on " + gID + "\" "; | |||
| if (reason != "") { | ||
| hoverText = "class=\"hoverable-cell\" data-hover-text=\""+userName+" received a "+std::to_string(daysExtended)+" day extension due to "+reason+" on "+gID+"\" "; | ||
| } else { | ||
| hoverText = "class=\"hoverable-cell\" data-hover-text=\""+userName+" received a "+std::to_string(daysExtended)+" day extension without specified reason on "+gID+"\" "; |
There was a problem hiding this comment.
looks like we lost the unspecified reason hover text in the refactor. please re-add below
bmcutler
requested changes
Jul 17, 2024
| @@ -109,6 +102,11 @@ TableCell::TableCell(float d, const std::string& c, int precision, const std::st | |||
| } else if (event == "Extension"){ | |||
| extension = true; | |||
| inquiry = bad_status = override = version_conflict = cancelled = false; | |||
| if (reason != ""){ | |||
| hoverText = "class=\"hoverable-cell\" data-hover-text=\"" + userName + " received a " + std::to_string(daysExtended) + " day extension due to " + reason + " on " + gID + "\" "; | |||
| if (reason != ""){ | ||
| hoverText = "class=\"hoverable-cell\" data-hover-text=\"" + userName + " received a " + std::to_string(daysExtended) + " day extension due to " + reason + " on " + gID + "\" "; | ||
| } else { | ||
| hoverText = "class=\"hoverable-cell\" data-hover-text=\""+userName+" received a "+std::to_string(daysExtended)+" day extension without specified reason on "+gID+"\" "; |
bmcutler
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Students aren't sure what the red outline on the grade report means since the description is at the bottom of the grade report page.
What is the new behavior?
A hover feature is now implemented to notify that the red outline cells are bad status, including the username of the student with a bad status and the homework/assignment that a bad status was received.
Other information?
Fixes #10439 (Submitty/Submitty#10439)
When the cursor is over the bad status cell this is the hover text that appears:
