Add build constraint file #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy 2.0 doesn't play well with some requirements of our python packages, i.e. spacy and thinc, used in FormFyxer. This change adds a build-contraint file, as inspired by https://thinc.ai/docs/install#extended, which will prevent python from trying to use numpy 2 when doing isolated builds. Since this file is best referenced from `https://raw.githubusercontent.com`, this commit will be merged into main first, and then a commit that references this file will be used in `publish/action.yml`.
This was referenced Jun 17, 2024
BryceStevenWilley
added a commit
that referenced
this pull request
Jun 17, 2024
Use the build-constraints.txt file when building all repos, to avoid using numpy 2 which can break spacy. Continues on the work done in #25. --- Tested on SuffolkLITLab/FormFyxer#136.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0 doesn't play well with some requirements of our python packages, i.e. spacy and thinc, used in FormFyxer.
This change adds a build-contraint file, as inspired by https://thinc.ai/docs/install#extended, which will prevent python from trying to use numpy 2 when doing isolated builds.
Since this file is best referenced from
https://raw.githubusercontent.com, this commit will be merged into main first, and then a commit that references this file will be used inpublish/action.yml.See SuffolkLITLab/FormFyxer#135
Have tested locally that this works, but running:
both on a project that is broken by the numpy 2 stuff (FormFyxer) and one that isn't (docassemble-EFSPIntegration), and both still run correctly with this file.