Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #160: Length Converter JS Extension #206

Closed
wants to merge 3 commits into from

Conversation

isha-dutta
Copy link
Contributor

Description

This interactive interface, crafted with HTML, CSS, and JavaScript, offers a seamless experience for converting lengths, allowing users to effortlessly switch between various units of measurement. It proves invaluable for professionals in engineering, design, and construction, while also serving as a handy tool for students studying measurement units. Its intuitive design enhances usability and streamlines daily tasks that necessitate quick and accurate length conversions.

Fixes: #160

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have made this from my own
  • I have taken help from some online resourses
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Screenshot 2024-05-16 013251

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@Sulagna-Dutta-Roy Sulagna-Dutta-Roy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked your code. Kindly add script files
Also change the directory name as Length Converter/your files

@isha-dutta
Copy link
Contributor Author

@Sulagna-Dutta-Roy Ma'am I would like you to look at the changes I made. Is it okay.

Copy link
Owner

@Sulagna-Dutta-Roy Sulagna-Dutta-Roy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly add script files. Also I can see that you didn't push the files with a new branch. Can you please close this one and open a new pull request. You can check this reference: #105

@isha-dutta isha-dutta closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Length Converter JS Extension
2 participants