Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Winner Notification and Play Again Functionality to Rock Paper Scissors Game #286

Conversation

thevijayshankersharma
Copy link
Contributor

Description

This update introduces a feature that displays a popup message when either the user or the CPU wins 5 games. The popup announces the winner and includes a 'Play Again' button that resets the game scores and state. Additionally, the sound functionality has been removed as it is no longer required.

Fixes: #264

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have made this from my own
  • I have taken help from some online resourses
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Screenshot 2024-05-18 073641

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@Sulagna-Dutta-Roy Sulagna-Dutta-Roy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add script files as it's an extension repository.

@thevijayshankersharma thevijayshankersharma deleted the Play-again-button branch May 20, 2024 00:33
@thevijayshankersharma thevijayshankersharma restored the Play-again-button branch May 20, 2024 00:33
@thevijayshankersharma
Copy link
Contributor Author

@Sulagna-Dutta-Roy its already there you can check once again. Here I am able to add extension too

image

@Sulagna-Dutta-Roy
Copy link
Owner

Please add manifest.json file.

@thevijayshankersharma
Copy link
Contributor Author

thevijayshankersharma commented May 20, 2024

As I said its already present

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rock Paper Scissor: Add Play Again Button and Winning Logic at 5 Wins
3 participants