chore(setup): store source manifests as json #3762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I need time to process it :hell_chart: |
| }, | ||
| "default_metrics_source": { | ||
| "config-name": "endpoint-metrics", | ||
| "name": "(default-metrics)" |
There was a problem hiding this comment.
just curious how come default metrics has parenthesis around it? 🤔
There was a problem hiding this comment.
Someone long ago decided it should be this way, changing it is painful, and it doesn't really hurt anyone.
sumo-drosiek
approved these changes
Jun 17, 2024
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of templating Terraform manifests in HCL, we instead do it in JSON. This is easier and less error-prone, as Helm lets us generate JSON directly from dictionaries in the Helm Chart configuration.
Note that we actually generate more than we need here. The other data will be used in subsequent changes from #3761, of which this change is a part of.