Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entangled units updates #324

Merged
merged 13 commits into from
Oct 16, 2024
Merged

Entangled units updates #324

merged 13 commits into from
Oct 16, 2024

Conversation

ddahlbom
Copy link
Member

Fixes several bugs, including:
- Error is Base.show
- Error in initializing an external field from existing system
- Error in updating external field
- Sign convention for external field

Adds:
- Dispersion tests for dimer model
- Intensity golden test for dimer model using classical dynamics
- Additional function aliasing (clone_system, dispersion, resize_supercell)

@ddahlbom ddahlbom requested a review from kbarros October 10, 2024 18:41
Copy link
Member

@kbarros kbarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

src/EntangledUnits/EntangledUnits.jl Outdated Show resolved Hide resolved
@ddahlbom
Copy link
Member Author

In response to a request from Daniel Pajerowski, added Sunny.coherent_state_from_dipoles, a function that constructs a coherent state for an entangled unit based on a set of dipoles for each atom inside the entangled unit. These dipoles are all assumed to be fully polarized.

It is not possible to write a well-defined set_dipole! function for entangled systems, since all dipoles within a unit must be set at once. This function offers another path to initialize an entangled system in a classical dipolar state.

Note that it would be possible to write a batch set_dipoles! function for an entangled system, and perhaps this should be added. It would also be possible to set the state of entangled system from the coherent states of an SU(N) unentangled system, which could take the form of a set_coherents! function.

@ddahlbom ddahlbom merged commit 397b41c into main Oct 16, 2024
4 checks passed
@ddahlbom ddahlbom deleted the entangled-units-refinements branch October 16, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants