-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entangled units updates #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
In response to a request from Daniel Pajerowski, added It is not possible to write a well-defined Note that it would be possible to write a batch |
Fixes several bugs, including:
- Error is
Base.show
- Error in initializing an external field from existing system
- Error in updating external field
- Sign convention for external field
Adds:
- Dispersion tests for dimer model
- Intensity golden test for dimer model using classical dynamics
- Additional function aliasing (
clone_system
,dispersion
,resize_supercell
)