Use Logging for info and warning printouts #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something strange with git happening here, be careful when you merge! But these changes look great. I think the default behavior should be to warn the user if they try to override an interaction, especially with the new way biquad is handled. |
|
There's a few more in https://github.com/search?q=repo%3ASunnySuite%2FSunny.jl%20println&type=code but this is probably an update-as-needed situation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATED
Only the first 5 site or pair coupling override warnings will be printed to the terminal. After that, the warnings will be suppressed.
Convert some
printlnstatements toLogging.@infoand@warnstatements. This is appropriate for providing a warning that the user wasn't expecting. Some functions, of the formprint_*explicitly promise to print something, and here theprintln()statements seem appropriate.