Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download contributed docs as .tgz #213

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Download contributed docs as .tgz #213

merged 6 commits into from
Jan 3, 2024

Conversation

ddahlbom
Copy link
Member

@ddahlbom ddahlbom commented Jan 3, 2024

I messed up a rebase, so I am redoing PR #210 here.

As before:

This PR addresses Issue #203. The Sunny doc building process no longer attempts a sparse checkout of the SunnyContributed build folder. Instead, the make file on the SunnyContributed side now stores the results of its build in a tarball, and this tarball is downloaded directly during the Sunny.jl doc build without using git.

Associated changes to SunnyContributed were made in this commit (see changes to make.jl).

@kbarros left the following comment on the earlier PR:

This looks nice and clean! The three new package dependencies (Downloads, Tar, CodecZlib) all seem pretty "Julia official".

The PR currently extracts into ./contributed-tmp and then copies to src/examples/contributed. Is there a reason not to directly extract into the latter?

    Tar.extract(tar, joinpath(@__DIR__, "src", "examples", "contributed")

Then we would no longer need contributed-tmp?

The suggestion has been incorporated.

@kbarros kbarros changed the title Download contributed docs Download contributed docs as .tgz Jan 3, 2024
@kbarros kbarros merged commit dc13228 into main Jan 3, 2024
4 checks passed
@kbarros kbarros deleted the contributed-build-to-tar branch January 3, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants