Numerically stable accumulation of intensity variance #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbarros
reviewed
Jan 3, 2024
test/test_correlation_sampling.jl
Outdated
| @@ -128,7 +128,7 @@ end | |||
| # Merge correlations and check if result equal to running calculation. | |||
| sc_merged = merge_correlations([sc1, sc2]) | |||
| @test sc0.data ≈ sc_merged.data | |||
| @test sc0.variance ≈ sc_merged.variance | |||
| @test sc0.M[1] ≈ sc_merged.M[1] | |||
There was a problem hiding this comment.
Should this hold for the whole M array?
|
Overall looks good to me, but maybe one test got weakened. Eventually we might want to consider merging with an |
|
Sorry, the weakened test was an oversight. It is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace running calculation of variance with running calculation of
M=(n-1)*σ², wherenis the number of samples.The modifications reproduce previous results when
Mis divided byn-1. Note that there is currently no interface for retrieving this data. Any future interface will need to divide byn-1to recover the variance.