Add --bail cli flag, exit with non-zero status if scanning results in error, fixes: #370#371
Open
vidhill wants to merge 2 commits intoSurnet:masterfrom
Open
Add --bail cli flag, exit with non-zero status if scanning results in error, fixes: #370#371vidhill wants to merge 2 commits intoSurnet:masterfrom
vidhill wants to merge 2 commits intoSurnet:masterfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
Is this change likely to get merged? Do I need to do anything? |
Collaborator
|
@vidhill I'm sorry for the late. I'm reviewing everything to get it merge to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature request #370
When using the
swagger-jsdoccli in an npm scriptIf the scan fails the process currently exits with an exit code
0which indicates successWhen running on CICD for example,
I would like the job to fail so the process would need to exit with non-zero code
This PR adds a cli flag (
--bail), when the flag is set exit with non-zero code if scanning failse.g.
If the scan fails, the script exits with code
1otherwise it exits with0as normal