Fix security vulnerabilities #425
Conversation
|
Thank you for this PR. I would like to see this PR merged. However, it appears that this project is no longer active. |
|
@martin-badin could you please merge this PR in our project we are blocked and it's impacting our production also |
|
Sorry. I am not owner. |
|
@daniloab Do you be able to review and merge this PR? |
Hey, I'm going to review. Sorry for the late. |
test/cli.spec.js
Outdated
| tryUnlink(`${dir}/swagger.json`); | ||
| tryUnlink(`${dir}/customSpec.json`); | ||
| tryUnlink(`${dir}/customSpec.yaml`); | ||
| tryUnlink(`${dir}/customSpec.yml`); |
There was a problem hiding this comment.
Can also just skip removing this non existent file (instead of wrapping in try/catch)
There was a problem hiding this comment.
Is this failing or the try catch is working as expected?
There was a problem hiding this comment.
Try catch is working as expected. But the .yml file doesn't exist - so we can alternatively just remove line 152 (like I do in my other PR).
There was a problem hiding this comment.
Given the code merged to main, this should already be done though obviously I don't have permissions to resolve conflicts here.
There was a problem hiding this comment.
yes, I'm trying to fix the yaml version first to keep working into the remaining PRs
There was a problem hiding this comment.
Sorry, missed this conversation. I've resolved the merge conflicts.
- Migrate from `swagger-parser` to successor `@apidevtools/swagger-parser` - Bump dev packages with security vulnerabilities - Fix cleanup issue with test when files do not exist
jpage-godaddy
force-pushed
the
upgrade-swagger-parser
branch
from
1c71314 to
6428771
Compare
|
Will need review from @daniloab (I don't have approval rights) |
|
Hey @daniloab, would be really nice to get this merged and a new release. Thanks in advance for everyones works! Highly appreciated :) |
Hey guys, sorry for the late. Running the flows. |
7 participants
swagger-parserto successor@apidevtools/swagger-parser