This repository was archived by the owner on Jul 21, 2025. It is now read-only.
forked from SeSAC-Flutter-6/debug_exam
-
Notifications
You must be signed in to change notification settings - Fork 29
fix: getTyA의 (yyyy-MM-dd)포맷 수정, getTyB의 ||를 &&로 수정, 첫번재조건을 <4로 수정 #17
Open
sujinlab
wants to merge
1
commit into
SurvivalCodingCampus:master
Choose a base branch
from
sujinlab:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "debug_exam", | ||
| "request": "launch", | ||
| "type": "dart" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,5 @@ | ||
| import 'package:dart_debug_sample/dart_debug_sample.dart'; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| void main() { | ||
| test('', () { | ||
|
|
||
| }); | ||
| test('', () {}); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 테스트 케이스 추가가 필요합니다. 코드 간소화는 좋지만,
테스트 케이스 구현을 도와드릴까요? 🤖 Prompt for AI Agents |
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
논리 연산자 수정이 올바르게 적용되었지만 시간대 누락이 있습니다.
시간 범위 체크에서
||를&&로 수정한 것은 정확합니다. 하지만 14-16시간대(오후 2-4시)에 대한 조건이 누락되어 있습니다.다음 수정을 적용하여 누락된 시간대를 추가하세요:
} else if (nowTime.hour >= 12 && nowTime.hour < 14) { return timeDataOne.first.ty6; + } else if (nowTime.hour >= 14 && nowTime.hour < 16) { + return timeDataOne.first.ty7; } else if (nowTime.hour >= 16 && nowTime.hour < 18) { - return timeDataOne.first.ty7; + return timeDataOne.first.ty8; } else if (nowTime.hour >= 18 && nowTime.hour < 20) { - return timeDataOne.first.ty8; + return timeDataOne.first.ty9; } else if (nowTime.hour >= 20 && nowTime.hour < 22) { - return timeDataOne.first.ty9; + return timeDataOne.first.ty10; } else if (nowTime.hour >= 22 && nowTime.hour < 24) { - return timeDataOne.first.ty10; + return timeDataOne.first.ty11;📝 Committable suggestion
🤖 Prompt for AI Agents