Skip to content

Chore/association model#10

Merged
AlexeiThornber merged 6 commits intomainfrom
chore/association-model
Oct 5, 2024
Merged

Chore/association model#10
AlexeiThornber merged 6 commits intomainfrom
chore/association-model

Conversation

@oskar-codes
Copy link
Collaborator

This pull request aims to integrate model classes for Associations, namely:

  • Data class for Associations
  • Data class for Users
  • AssociationRepository interface
  • AssociationRepositoryFirestore implementing the aforementionned interface using Firestore

Two tests, respectively for the AssociationRepository and the User, are included.

@oskar-codes oskar-codes linked an issue Oct 4, 2024 that may be closed by this pull request
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Copy link
Contributor

@Aurelien9Code Aurelien9Code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look very good to me for now. We might just add in a future a 'parent' association and a 'child' association, both set to Null at first. So that small commissions could join the project before their parent association, and be linked to it after. And so that big associations could register at once all their commissions (if they are not already in the project).

Copy link
Collaborator

@AlexeiThornber AlexeiThornber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later on, change the Association data class to better define val members : List<String>.

@AlexeiThornber AlexeiThornber merged commit 991beaf into main Oct 5, 2024
@AlexeiThornber AlexeiThornber deleted the chore/association-model branch October 5, 2024 09:37
@oskar-codes
Copy link
Collaborator Author

@AlouchLaBouche Indeed, in a later pull request I will add a computed property that is automatically populated with the complete member data.

Copy link
Collaborator

@leagrieder leagrieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

This is an excellent PR! Here are some highlights:

  • Description: Clear and to the point, making it easy to understand the changes and their context.
  • Tests: Your tests are thorough and well-structured, covering all relevant scenarios.
  • Commit Messages: Consistently great, providing clarity and context for each change.

Overall, a well-executed PR. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement association repository and data model

4 participants