Conversation
…ts Firestore implementation.
This was done in chore/association-model because associations depend on the User class.
Other tests will be added to this file as user-related functionalities are added to the project.
…on of the AssociationRepository
|
Aurelien9Code
left a comment
There was a problem hiding this comment.
This look very good to me for now. We might just add in a future a 'parent' association and a 'child' association, both set to Null at first. So that small commissions could join the project before their parent association, and be linked to it after. And so that big associations could register at once all their commissions (if they are not already in the project).
|
@AlouchLaBouche Indeed, in a later pull request I will add a computed property that is automatically populated with the complete member data. |
leagrieder
left a comment
There was a problem hiding this comment.
PR Review
This is an excellent PR! Here are some highlights:
- Description: Clear and to the point, making it easy to understand the changes and their context.
- Tests: Your tests are thorough and well-structured, covering all relevant scenarios.
- Commit Messages: Consistently great, providing clarity and context for each change.
Overall, a well-executed PR. Great work!



This pull request aims to integrate model classes for Associations, namely:
Two tests, respectively for the AssociationRepository and the User, are included.