Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/Figma adaptations pt2 #321

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Chore/Figma adaptations pt2 #321

merged 2 commits into from
Dec 19, 2024

Conversation

Zafouche
Copy link
Collaborator

@Zafouche Zafouche commented Dec 19, 2024

Description

The purpose of this PR is to fix the small inconsistencies between the Figma and the actual implementation.
This PR is the continuation of a work that was started in #307 and takes care of coding issues listed in this issue.

Motivation and Context

The reason behind this PR is simply to improve consistency between our design and our implementation, and make sure we haven't forgotten to implement anything what was designed.

Welcome

  • Added clear button to the email input field.

Map

  • Corrected timer string formatter to have spaces between words.

@Zafouche Zafouche added enhancement New feature or request refactor Restructure/rework so as to improve operation without altering functionality labels Dec 19, 2024
@Zafouche Zafouche marked this pull request as ready for review December 19, 2024 17:38
@Zafouche
Copy link
Collaborator Author

Feel free to add small adjustments here if I forgot something, but I went through the entire app, and only Figma adjustments remain. So I'm opening this for review.

Copy link
Collaborator

@Redd87 Redd87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zafouche Zafouche merged commit 39222bc into main Dec 19, 2024
3 checks passed
@Zafouche Zafouche deleted the chore/figma-adaptations-pt2 branch December 19, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Restructure/rework so as to improve operation without altering functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figma: Check other screen inconsistencies that aren't listed in the existing tasks and fix them
2 participants