Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency duende.accesstokenmanagement to 3.2.0 [security] #905

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marvin-serp-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
Duende.AccessTokenManagement (source) nuget minor 2.0.3 -> 3.2.0

GitHub Vulnerability Alerts

CVE-2025-26620

Summary

Duende.AccessTokenManagement contains a race condition when requesting access tokens using the client credentials flow. Concurrent requests to obtain an access token using differing protocol parameters can return access tokens obtained with the wrong scope, resource indicator, or other protocol parameters. Such usage is somewhat atypical, and only a small percentage of users are likely to be affected.

Details

Duende.AccessTokenManagement can request access tokens using the client credentials flow in several ways. In basic usage, the client credentials flow is configured once and the parameters do not vary. In more advanced situations, requests with varying protocol parameters may be made by calling specific overloads of these methods:

  • HttpContext.GetClientAccessTokenAsync()
  • IClientCredentialsTokenManagementService.GetAccessTokenAsync()

There are overloads of both of these methods that accept a TokenRequestParameters object that customizes token request parameters. However, concurrent requests with varying TokenRequestParameters will result in the same token for all concurrent calls.

Upgrading

Most users can simply update the NuGet package to the latest version. Customizations of the IClientCredentialsTokenCache that derive from the default implementation (DistributedClientCredentialsTokenCache) will require a small code change, as its constructor was changed to add a dependency on the ITokenRequestSynchronization service. The synchronization service will need to be injected into the derived class and passed to the base constructor.

Impact

The impact of this vulnerability depends on how Duende.AccessTokenManagement is used and on the security architecture of the solution. Most users will not be vulnerable to this issue. More advanced users may run into this issue by calling the methods specified above with customized token request parameters. The impact of obtaining an access token with different than intended protocol parameters will vary depending on application logic, security architecture, and the authorization policy of the resource servers.

Thank you to Michael Dimoudis of PageUp for finding this issue and responsibly disclosing it!


Release Notes

DuendeSoftware/foss (Duende.AccessTokenManagement)

v3.2.0

Compare Source

v3.1.1

Compare Source

v3.1.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" in timezone Europe/London, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@marvin-serp-bot marvin-serp-bot requested a review from a team as a code owner February 19, 2025 20:06
Copy link

✒️ PR Title Commitlint - ✔️ Lint success!

@marvin-serp-bot marvin-serp-bot force-pushed the upgrade/nuget-duende.accesstokenmanagement-vulnerability branch from 2afdc58 to 93fd0ea Compare February 21, 2025 14:04
@marvin-serp-bot marvin-serp-bot force-pushed the upgrade/nuget-duende.accesstokenmanagement-vulnerability branch from 93fd0ea to e020ee0 Compare February 25, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants