Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2269 revert syntax import svg path in entry LESS files #896

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

goldenraphti
Copy link
Collaborator

Description

https://payexjira.atlassian.net/browse/SWED-2269
Fixing bug mentioned in Slack : https://payex.slack.com/archives/C0L3W8B2S/p1686920342011129
when, during migration away from LESS to pure CSS we converted stylesheets imports from @import "components/accordion"; to @import url("components/accordion");, it broke the paths for files loading inside CSS values (e.g. checkbox, check-mark).
We did this change because it was the Stylelint default. But this change of syntax is NOT needed, both ways are supposed to be equal in CSS W3C spec (just checked ✅ ).

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #896 (6a913ac) into develop (4e692c8) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #896   +/-   ##
========================================
  Coverage    72.91%   72.91%           
========================================
  Files          211      211           
  Lines         4478     4478           
  Branches      1244     1244           
========================================
  Hits          3265     3265           
  Misses        1077     1077           
  Partials       136      136           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb177aa...6a913ac. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Size Change: 0 B

Total Size: 1.1 MB

ℹ️ View Unchanged
Filename Size
dist/designguide/scripts/dg-dashboard.js 72.9 kB
dist/designguide/scripts/dg.js 24.5 kB
dist/designguide/styles/documentation-payex.css 8.19 kB
dist/designguide/styles/documentation-swedbankpay.css 7.29 kB
dist/designguide/styles/payex.css 41 kB
dist/designguide/styles/swedbankpay.css 38.9 kB
dist/scripts/9438.js 71.8 kB
dist/scripts/dg-dashboard.js 72.9 kB
dist/scripts/dg.js 24.5 kB
dist/scripts/payex.js 322 kB
dist/scripts/swedbankpay.js 322 kB
dist/styles/documentation-payex.css 8.19 kB
dist/styles/documentation-swedbankpay.css 7.29 kB
dist/styles/payex.css 41 kB
dist/styles/swedbankpay.css 38.9 kB

compressed-size-action

@goldenraphti goldenraphti merged commit ef2ba3a into develop Aug 23, 2023
8 checks passed
@github-actions github-actions bot deleted the feature/SWED-2269-import_svg_path branch August 23, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants