Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2266 disable dropdown icon rotation #901

Merged

Conversation

goldenraphti
Copy link
Collaborator

Description

https://payexjira.atlassian.net/browse/SWED-2266

Motivation and Context

offer a way for devs to disable the toggle-icon rotation happening be default on active state

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #901 (a5ecd5d) into develop (3e82f62) will decrease coverage by 0.06%.
Report is 3 commits behind head on develop.
The diff coverage is 42.85%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #901      +/-   ##
===========================================
- Coverage    72.91%   72.85%   -0.06%     
===========================================
  Files          211      211              
  Lines         4478     4484       +6     
  Branches      1244     1249       +5     
===========================================
+ Hits          3265     3267       +2     
- Misses        1077     1081       +4     
  Partials       136      136              
Files Changed Coverage Δ
...entsDocumentation/components/Dropdown/constants.js 31.81% <ø> (ø)
...mponentsDocumentation/components/Dropdown/index.js 61.11% <ø> (ø)
src/App/Home/constants.js 100.00% <ø> (ø)
src/App/components/Dropdown/index.js 66.66% <42.85%> (-4.45%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22a93b...a5ecd5d. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

Size Change: +670 B (0%)

Total Size: 1.1 MB

Filename Size Change
dist/designguide/styles/payex.css 41.1 kB +135 B (0%)
dist/designguide/styles/swedbankpay.css 39.1 kB +148 B (0%)
dist/styles/payex.css 41.1 kB +135 B (0%)
dist/styles/swedbankpay.css 39.1 kB +148 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.5 kB 0 B
dist/designguide/styles/documentation-payex.css 8.21 kB +23 B (0%)
dist/designguide/styles/documentation-swedbankpay.css 7.32 kB +29 B (0%)
dist/scripts/9438.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.5 kB 0 B
dist/scripts/payex.js 322 kB 0 B
dist/scripts/swedbankpay.js 322 kB 0 B
dist/styles/documentation-payex.css 8.21 kB +23 B (0%)
dist/styles/documentation-swedbankpay.css 7.32 kB +29 B (0%)

compressed-size-action

@goldenraphti goldenraphti merged commit 372b4f7 into develop Aug 31, 2023
8 checks passed
@github-actions github-actions bot deleted the feature/SWED-2266-disable_dropdown_icon_rotation branch August 31, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants