SWED-2249 create playbook doc #908
Conversation
goldenraphti
changed the title
|
Size Change: +3.59 kB (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
reason of changes: we removed the Overview page from Identity section. Therfore each idenity page only has a link in the sidebar, there is no morelink in the (removed) Overview page. Now landing page for Identity is Accessibility
src/App/Home/index.js
Outdated
There was a problem hiding this comment.
Reason of change:
Playbook is only for SwedbankPay.
So the homepage will still have only 4 quick-access cards. And whether it's SwedbankPay or PayEx one of them will either be Playbook Or Patterns
| {/* <source | ||
| type="image/avif" | ||
| media="(min-width: 576px)" | ||
| srcSet={`${basename}img/documentation/playbook/playbook-showroom-2.avif`} | ||
| /> */} |
There was a problem hiding this comment.
Reasoning:
"Why keeping code commented-out?" You want to ask ?
- Well, great question !! (I first added the images in avif too, to get better web-perf. But then designers asked me to yet increase the quality of the images. My issue is that I think the quality is good enough (3x everywhere) and I converted to avif in as high quality as possible and lossless. And with all the img/media content on this page the computers and phones are struggling to process and paint it all fluidly (well, they really struggle on a non 3000$ machine such as the crappy old laptop I am using, and several videos cannot even play). I do suspect this decision will change in the near future in an iteration for the necessity of actually having the page displaying its content fluidely even if it means slightly less quality). So here it is, ready to be un-commented at the snap of a finger 😉🤫
| @@ -720,6 +720,183 @@ | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Note of the dev:
I am not 100% happy with all this .playbook-* styling. At all.
I think there is clearly room for simplification, reformatting it to have less "1 case rules".
So far we're a bit in a rush, so here it is.
Plus this is documentation website style only, and not even for the components, so it's (in my opinion) much less important to get it super nice and clean.
But I do want to go through it all again and improve & clean what can be 👍
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #908 +/- ##
===========================================
- Coverage 72.65% 72.60% -0.06%
===========================================
Files 211 212 +1
Lines 4498 4508 +10
Branches 1257 1263 +6
===========================================
+ Hits 3268 3273 +5
- Misses 1093 1097 +4
- Partials 137 138 +1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
I think it looks good!
It is interesting to see the "conflict" on the user's loading time vs quality of the visualisations on the page.
I think it is important to make our product available. However, if the users are developers with good internet connection and fast computers we might not have to have this discussion as prio 1. it would be nice with some guidelines on what to prioritise.
Nice job ✅
|
bypassing approval since it was approved by Marius, and only had to modify the release-notes markdown for merge-conflict 😉 |
Don't get scared by the amount of files changed. Most of it (160 files) is image & video files, each with their own formats (images =
.png+.avif, and videos are in.mp4but in both the classic codec and asAV1encoded, for performance reasons)Also, since the sidebar got a new section, many tests files snapshots and screenshots had to be updated 😛 (3 screenshots)
Description
add the Playbook section to the DS documentation website
https://payexjira.atlassian.net/browse/SWED-2249
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Review instructions
Review instructions