-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWED-2279 color page update #914
Conversation
- remove images system-color - replace CSS variables by hex in color swatches for color-pool - comment out CSS variables from color-pool - containerize grid color-pool
- fix container safari - fix sbp custom-prop
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #914 +/- ##
===========================================
- Coverage 72.31% 72.30% -0.01%
===========================================
Files 212 212
Lines 4573 4586 +13
Branches 1302 1306 +4
===========================================
+ Hits 3307 3316 +9
- Misses 1122 1126 +4
Partials 144 144
Continue to review full report in Codecov by Sentry.
|
Size Change: +3.12 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Description
https://payexjira.atlassian.net/browse/SWED-2279
Rewrite of the Colors page,
and I took advantage of being in the middle of the colors to do some modifications on color variables and add E2E testing to the page.
I will create E2E tests specifically dedicated to testing whether all the color CSS custom properties are actually defined in a later ticket. I'll probably bundle it in a ticket where I continue on the migration from LESS variables to pure CSS variables.
It looks like a huuuge PR. And, to be fair, it is a pretty big one. But don't get scared off by the amount of files changed:
basically, only about 10-15 files require attention 😉 👍
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Review instructions
Review instructions