Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using swiftlang repo instead of apple, as Apple transitioned already #96

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

MojtabaHs
Copy link
Contributor

@MojtabaHs MojtabaHs commented Aug 29, 2024

Using the apple repo will conflict with the swiftlang version and will be considered an error in an upcoming SPM release.

@MojtabaHs MojtabaHs changed the title Switch to using the new swift-syntax from swiftlang instead of apple, as Apple transitioned it already Switch to using the same swift-syntax BUT from swiftlang instead of apple, as Apple transitioned it already Aug 31, 2024
Package.swift Outdated Show resolved Hide resolved
@MojtabaHs MojtabaHs changed the title Switch to using the same swift-syntax BUT from swiftlang instead of apple, as Apple transitioned it already Switch to using swiftlang repo instead of apple, as Apple transitioned already Sep 17, 2024
@soumyamahunt
Copy link
Contributor

@MojtabaHs CI is failing, can you rebase your branch?

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (e3e06b3) to head (8b61e52).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         109      109           
  Lines        3896     3896           
=======================================
  Hits         3703     3703           
  Misses        193      193           
Flag Coverage Δ
95.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soumyamahunt soumyamahunt merged commit b929e06 into SwiftyLab:main Sep 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants