Skip to content

Conversation

@olevski
Copy link
Member

@olevski olevski commented Jul 24, 2025

This replaces the original PR which used a branch from a fork.

@olloz26 I will add you to the repo so that you can use this. The main reason for the PR is so that I can open my PR that rebases your old branch on top of main. EDIT: You already have write permissions to this repo. So you don't need the fork anymore.

That way when you start working on this you wont have to spend that much time refactoring.

replaces #299

/deploy renku-ui=olloz26/openbis-data-connectors

@olevski olevski requested a review from a team as a code owner July 24, 2025 18:44
@olevski olevski marked this pull request as draft July 24, 2025 18:45
@olevski olevski force-pushed the pitch/connect-renkulab-and-openbis-datasets branch from 5516d0e to 67dd950 Compare July 24, 2025 22:48
@olloz26 olloz26 force-pushed the pitch/connect-renkulab-and-openbis-datasets branch from 67dd950 to 6968ea0 Compare October 22, 2025 11:22
@olloz26 olloz26 force-pushed the pitch/connect-renkulab-and-openbis-datasets branch from 6968ea0 to 93c9739 Compare October 22, 2025 11:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18715077147

Details

  • 70 of 139 (50.36%) changed or added relevant lines in 12 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 86.653%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/api/schemas/cloud_storage.py 0 9 0.0%
components/renku_data_services/storage/rclone.py 7 20 35.0%
components/renku_data_services/data_connectors/blueprints.py 18 33 54.55%
components/renku_data_services/utils/core.py 5 37 13.51%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/pagination.py 1 88.16%
components/renku_data_services/session/models.py 1 95.79%
components/renku_data_services/notebooks/api/schemas/cloud_storage.py 2 31.11%
Totals Coverage Status
Change from base Build 18714790649: -0.1%
Covered Lines: 22781
Relevant Lines: 26290

💛 - Coveralls

@olevski olevski marked this pull request as ready for review October 30, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants