Skip to content

Conversation

wesjdj
Copy link

@wesjdj wesjdj commented Jul 15, 2025

No description provided.

@wesjdj wesjdj force-pushed the add-ci-deployment-cleanup branch from 7653acf to 232e567 Compare July 15, 2025 11:15
@wesjdj wesjdj marked this pull request as ready for review July 15, 2025 11:59
@wesjdj wesjdj requested a review from leafty July 15, 2025 11:59
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments here:

@leafty
Copy link
Member

leafty commented Aug 6, 2025

@wesjdj feel free to merge this

if [ "$ENFORCE_NAME_PATTERNS" = "true" ]; then
for pattern in $NAMESPACE_PATTERNS; do
debug_log "Testing pattern: $pattern"
if [[ "$namespace" =~ $pattern ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't work for lookahead regex patterns like ^renku-ci-(?!cleanup).* so we should make sure not to use those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants