-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add renku-ci-cleanup chart #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7653acf
to
232e567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments here:
@wesjdj feel free to merge this |
if [ "$ENFORCE_NAME_PATTERNS" = "true" ]; then | ||
for pattern in $NAMESPACE_PATTERNS; do | ||
debug_log "Testing pattern: $pattern" | ||
if [[ "$namespace" =~ $pattern ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't work for lookahead regex patterns like ^renku-ci-(?!cleanup).*
so we should make sure not to use those
No description provided.