Skip to content

Fix player level tooltip and add unitframe target name position #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KushGene wants to merge 2 commits into
base: era_sod
Choose a base branch
from
Open

Fix player level tooltip and add unitframe target name position #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
550ee78
Fix tooltip: show guild + level for players
KushGene Jan 5, 2026
2d8bc99
UnitFrames: add target name position option
KushGene Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Config/_Gui.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,20 @@ function Gui:OnEnable()
order = 1
}
},
{
mobnamepos = {
key = 'unitframes.mobnamepos',
type = 'dropdown',
label = 'Target Name Position',
options = {
{ value = 'above', text = 'Above Healthbar' },
{ value = 'below', text = 'Below Healthbar' },
{ value = 'inbar', text = 'In Healthbar' }
},
column = 4,
order = 2
}
},
{
textsize = {
key = 'unitframes.textsize',
Expand Down
1 change: 1 addition & 0 deletions Core/Init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ local defaults = {
hitindicator = false,
links = false,
elite = false,
mobnamepos = 'above',
size = 1,
textsize = 11,
player = {
Expand Down
95 changes: 88 additions & 7 deletions Modules/Tooltip/_Core.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,16 +131,97 @@ function Module:OnEnable()
cfg.barColor = color
GameTooltipStatusBar:SetStatusBarColor(color.r, color.g, color.b)
_G["GameTooltipTextLeft1"]:SetTextColor(color.r, color.g, color.b)
--color textleft2 by guildcolor
--guild + level lines
local guildName, guildRank = GetGuildInfo(unit)
local playerLevel = UnitLevel(unit)

local function GetLine(i)
return _G["GameTooltipTextLeft" .. i]
end

local function GetLineText(i)
local line = GetLine(i)
return line and line:GetText() or nil
end

local function FindLineByTextPredicate(minLine, maxLine, predicate)
for i = minLine, maxLine do
local text = GetLineText(i)
if text and text ~= "" and predicate(text, i) then
return i
end
end
return nil
end

local function FindEmptyLine(minLine, maxLine)
for i = minLine, maxLine do
local text = GetLineText(i)
if not text or text == "" then
return i
end
end
return nil
end

local maxLine = math.min(self:NumLines() or GameTooltip:NumLines(), 15)

if guildName then
_G["GameTooltipTextLeft2"]:SetText("<" .. guildName .. "> [" .. guildRank .. "]")
_G["GameTooltipTextLeft2"]:SetTextColor(unpack(cfg.guildColor))
local guildFormatted = "<" .. guildName .. ">" .. (guildRank and (" [" .. guildRank .. "]") or "")

local guildIndex = FindLineByTextPredicate(2, maxLine, function(text)
return text:find(guildName, 1, true) ~= nil
end)

if not guildIndex then
guildIndex = 2
local preserved = GetLineText(2)

local line2 = GetLine(2)
if line2 then
line2:SetText(guildFormatted)
line2:SetTextColor(unpack(cfg.guildColor))
end

if preserved and preserved ~= "" and preserved:find(guildName, 1, true) == nil then
local emptyIndex = FindEmptyLine(3, maxLine)
if emptyIndex then
local emptyLine = GetLine(emptyIndex)
if emptyLine then
emptyLine:SetText(preserved)
self:Show()
end
else
self:AddLine(preserved)
self:Show()
maxLine = math.min(self:NumLines() or GameTooltip:NumLines(), 15)
end
end
else
local guildLine = GetLine(guildIndex)
if guildLine then
guildLine:SetText(guildFormatted)
guildLine:SetTextColor(unpack(cfg.guildColor))
end
end
end

local levelIndex
if playerLevel and playerLevel > 0 then
local levelStr = tostring(playerLevel)
levelIndex = FindLineByTextPredicate(2, maxLine, function(text)
if guildName and text:find(guildName, 1, true) then return false end
return text:find(levelStr, 1, true) ~= nil
end)
end

if levelIndex then
local levelLine = GetLine(levelIndex)
if levelLine then
local lvlColor = GetCreatureDifficultyColor((playerLevel > 0) and playerLevel or 999)
levelLine:SetTextColor(lvlColor.r, lvlColor.g, lvlColor.b)
end
end
local levelLine = guildName and _G["GameTooltipTextLeft3"] or _G["GameTooltipTextLeft2"]
local l = UnitLevel(unit)
local color = GetCreatureDifficultyColor((l > 0) and l or 999)
levelLine:SetTextColor(color.r, color.g, color.b)
--afk?
if UnitIsAFK(unit) then
self:AppendText((" |cff%s<AFK>|r"):format(cfg.afkColorHex))
Expand Down
16 changes: 14 additions & 2 deletions Modules/UnitFrames/_Target.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ function Module:OnEnable()
texture = SUI.db.profile.general.texture,
size = SUI.db.profile.unitframes.size,
pvpbadge = SUI.db.profile.general.pvpbadge,
mobnamepos = SUI.db.profile.unitframes.mobnamepos,
module = SUI.db.profile.modules.unitframes
}

Expand All @@ -15,13 +16,24 @@ function Module:OnEnable()
--FocusFrame:SetScale(db.size)

local function SUITargetFrame(self, forceNormalTexture)
local function ApplyMobNamePosition()
if not self.name or not self.healthbar then return end
self.name:ClearAllPoints()
if db.mobnamepos == 'below' then
self.name:SetPoint("TOPLEFT", self.healthbar, "BOTTOMLEFT", 10, -2)
elseif db.mobnamepos == 'inbar' then
self.name:SetPoint("CENTER", self.healthbar, "CENTER", 0, 0)
else
self.name:SetPoint("BOTTOMLEFT", self.healthbar, "TOPLEFT", 10, 2)
end
end

if (db.style == 'Big') then
local classification = UnitClassification(self.unit);
self.highLevelTexture:SetPoint("CENTER", self.levelText, "CENTER", 0, 0);
self.deadText:SetPoint("CENTER", self.healthbar, "CENTER", 0, 0);
self.nameBackground:Hide();
--self.threatIndicator:SetTexture([[Interface\TargetingFrame\UI-TargetingFrame-Flash]]);
self.name:SetPoint("LEFT", self, 15, 36);
self.healthbar:SetSize(119, 26);
self.healthbar:SetPoint("TOPLEFT", 5, -24);
if (self.healthbar.LeftText) then
Expand Down Expand Up @@ -73,7 +85,6 @@ function Module:OnEnable()
if (classification == "minus") then
self.Background:SetSize(119, 12);
self.Background:SetPoint("BOTTOMLEFT", self, "BOTTOMLEFT", 7, 47);
self.name:SetPoint("LEFT", self, 16, 19);
self.healthbar:ClearAllPoints();
self.healthbar:SetPoint("LEFT", 5, 3);
self.healthbar:SetHeight(12);
Expand Down Expand Up @@ -107,6 +118,7 @@ function Module:OnEnable()
end
end
self.healthbar.lockColor = true;
ApplyMobNamePosition()
end

if (db.texture ~= 'Default') then
Expand Down