Improved dumper script and a Kaitai Struct spec. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved the spec for PocketBook swupdate.bin: Added an additional enum value for uboot. Added some metadata. Renamed the file to match the id. Improved dumper script: Replaced reading file into memory with with memory mapping. Added a mode to not to name dumps using hashes, but name with simple numbers. Files are placed relative to the unpacked image. Added shebang and made executable. Reordered the imports with isort.
|
ping |
|
Great PR, thanks :) Report here: #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the spec for PocketBook swupdate.bin:
Added an additional enum value for uboot.
Added some metadata.
Renamed the file to match the id.
Improved dumper script:
Replaced reading file into memory with with memory mapping.
Added a mode to not to name dumps using hashes, but name with simple numbers.
Files are placed relative to the unpacked image.
Added shebang and made executable.
Reordered the imports with isort.