Fixed Constructor Not Receiving Args as an Array #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a BC break. Why is it needed? |
According to the ML's docs, this is how we need to pass and accept parameters otherwise those configurations are not getting updated. |
|
Those docs do not show the converter accepting an array; it shows normal function parameters, as it uses already. The array is used to tell ML what the params are, which is quite separate. |
|
I meant this
|
|
I merged this manually, made a bunch of other changes and released it as 2.0.0. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the constructor of the AudioWaveform class was not correctly receiving arguments as an array.