Skip to content

Replace obsolete string.join with ''.join #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/SOAPpy/Parser.py
Original file line number Diff line number Diff line change
@@ -6,7 +6,6 @@
from .Utilities import *
import six

import string
import xml.sax
from wstools.XMLname import fromXMLname
import collections
@@ -222,7 +221,7 @@ def endElementNS(self, name, qname):
if href:
if href[0] != '#':
raise Error("Non-local hrefs are not yet suppported.")
if self._data != None and string.join(self._data, "").strip() != '':
if self._data != None and "".join(self._data).strip() != '':
raise Error("hrefs can't have data")

href = href[1:]
@@ -334,14 +333,14 @@ def endElementNS(self, name, qname):

# XXX What if rule != kind?
if isinstance(rule, collections.Callable):
data = rule(string.join(self._data, ""))
data = rule("".join(self._data))
elif type(rule) == DictType:
data = structType(name = (ns, name), attrs = attrs)
elif rule[1][:9] == 'arrayType':
data = self.convertType(cur.contents,
rule, attrs)
else:
data = self.convertType(string.join(self._data, ""),
data = self.convertType("".join(self._data),
rule, attrs)

break