move record point to before volume

SynthstromAudible · Jan 12, 2025 · 5d6424b · 5d6424b
1 parent 40562f8
commit 5d6424b
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/deluge/model/global_effectable/global_effectable_for_clip.cpp b/src/deluge/model/global_effectable/global_effectable_for_clip.cpp
@@ -140,6 +140,11 @@ GlobalEffectableForClip::GlobalEffectableForClip() {
 	processFXForGlobalEffectable(globalEffectableBuffer, numSamples, &volumePostFX, paramManagerForClip,
 	                             delayWorkingState, renderedLastTime, reverbSendAmount);
 	processStutter(globalEffectableBuffer, numSamples, paramManagerForClip);
+	// record before pan/compression/volume to keep volumes consistent
+	if (recorder && recorder->status < RecorderStatus::FINISHED_CAPTURING_BUT_STILL_WRITING) {
+		// we need to double it because for reasons I don't understand audio clips max volume is half the sample volume
+		recorder->feedAudio((int32_t*)globalEffectableBuffer, numSamples, true, 2);
+	}
 
 	processReverbSendAndVolume(globalEffectableBuffer, numSamples, reverbBuffer, volumePostFX, postReverbVolume,
 	                           reverbSendAmount, pan, true);
@@ -149,10 +154,7 @@ GlobalEffectableForClip::GlobalEffectableForClip() {
 	else {
 		compressor.reset();
 	}
-	if (recorder && recorder->status < RecorderStatus::FINISHED_CAPTURING_BUT_STILL_WRITING) {
-		// we need to double it because for reasons I don't understand audio clips max volume is half the sample volume
-		recorder->feedAudio((int32_t*)globalEffectableBuffer, numSamples, true, 2);
-	}
+
 	addAudio(globalEffectableBuffer, outputBuffer, numSamples);
 
 	postReverbVolumeLastTime = postReverbVolume;