Added Junit test cases for customer controller

src/main/java/com/bankofspring/api/v1/controller/CustomerController.java

@@ -22,20 +22,19 @@
 @RequestMapping("/v1/customer")
 public class CustomerController {
     @Autowired
-    CustomerService customerService;
+    private CustomerService customerService;
 
     @Autowired
-    ModelMapper mapper;
+    private ModelMapper mapper;
 
     @GetMapping(value = "/")
     public List<CustomerDto> getAllCustomers() {
         List<Customer> customers = customerService.getAllCustomers();
         if (customers != null && !customers.isEmpty()) {
-            List<CustomerDto> customerDtos = customers
+            return customers
                     .stream()
                     .map(customer -> mapper.map(customer, CustomerDto.class))
                     .collect(Collectors.toList());
-            return customerDtos;
         }
         return Collections.emptyList();
     }
@@ -44,8 +43,7 @@ public List<CustomerDto> getAllCustomers() {
     public CustomerDto getCustomer(@PathVariable("ssn") String ssn) throws EntityNotFoundException {
         Customer customer = customerService.getCustomer(ssn);
         if (customer != null) {
-            CustomerDto resultCustomer = mapper.map(customer, CustomerDto.class);
-            return resultCustomer;
+            return mapper.map(customer, CustomerDto.class);
         }
         return null;
     }
@@ -55,8 +53,7 @@ public CustomerDto createCustomer(@RequestBody @Valid CreateCustomerRequest crea
         CustomerDto customerDto = mapper.map(createCustomerRequest, CustomerDto.class);
         Customer customer = customerService.createCustomer(customerDto);
         if (customer != null) {
-            CustomerDto resultCustomer = mapper.map(customer, CustomerDto.class);
-            return resultCustomer;
+            return mapper.map(customer, CustomerDto.class);
         }
         return null;
     }

src/test/java/com/bankofspring/test/controller/CustomerControllerTest.java

@@ -0,0 +1,120 @@
+package com.bankofspring.test.controller;
+
+import static org.hamcrest.collection.IsCollectionWithSize.hasSize;
+import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+
+import org.junit.Before;
+import org.junit.FixMethodOrder;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.MethodSorters;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.http.MediaType;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.test.context.junit4.SpringRunner;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
+import org.springframework.test.web.servlet.setup.MockMvcBuilders;
+import org.springframework.web.context.WebApplicationContext;
+import com.bankofspring.BankOfSpringApplication;
+
+/**
+ * Created by Arpit Khandelwal.
+ */
+@RunWith(SpringRunner.class)
+@ContextConfiguration(classes = BankOfSpringApplication.class)
+@FixMethodOrder(MethodSorters.NAME_ASCENDING)
+@SpringBootTest
+public class CustomerControllerTest {
+    private MockMvc mockMvc;
+
+    @Autowired
+    private WebApplicationContext wac;
+
+    @Before
+    public void setup() {
+        this.mockMvc = MockMvcBuilders.webAppContextSetup(wac).build();
+    }
+
+    @Test
+    public void ut1_GetAllCustomers() throws Exception{
+        mockMvc
+                .perform(MockMvcRequestBuilders.get("/v1/customer/").accept(MediaType.APPLICATION_JSON))
+                .andExpect(status().isOk())
+                .andExpect(jsonPath("$", hasSize(5)))
+                .andDo(print());
+    }
+
+    @Test
+    public void ut2_GetCustomerBySsn() throws Exception{
+        mockMvc
+                .perform(MockMvcRequestBuilders.get("/v1/customer/AK01").accept(MediaType.APPLICATION_JSON))
+                .andExpect(status().isOk())
+                .andExpect(jsonPath("$.customerId").exists())
+                .andExpect(jsonPath("$.name").exists())
+                .andExpect(jsonPath("$.ssn").exists())
+                .andExpect(jsonPath("$.address1").exists())
+                .andExpect(jsonPath("$.address2").exists())
+                .andExpect(jsonPath("$.city").exists())
+                .andExpect(jsonPath("$.contactNumber").exists())
+                .andExpect(jsonPath("$.customerId").value(1))
+                .andExpect(jsonPath("$.name").value("Arpit K"))
+                .andExpect(jsonPath("$.ssn").value("AK01"))
+                .andExpect(jsonPath("$.address1").value("VT1"))
+                .andExpect(jsonPath("$.address2").value("Marine Bay1"))
+                .andExpect(jsonPath("$.city").value("Indore"))
+                .andExpect(jsonPath("$.contactNumber").value("9425094250"))
+                .andDo(print());
+    }
+
+    @Test
+    public void ut3_CreateCustomer() throws Exception{
+        mockMvc
+                .perform(MockMvcRequestBuilders.post("/v1/customer/create")
+                        .contentType(MediaType.APPLICATION_JSON)
+                        .content("{\"name\":\"Test Customer\", \"ssn\":\"TK01\", \"contactNumber\":\"9425094255\",\"address1\":\"Unit-Test\",\"address2\":\"Spring-Boot\",\"city\":\"SpringCity\"}")
+                        .accept(MediaType.APPLICATION_JSON))
+                .andExpect(status().isOk())
+                .andExpect(jsonPath("$.customerId").exists())
+                .andExpect(jsonPath("$.name").exists())
+                .andExpect(jsonPath("$.ssn").exists())
+                .andExpect(jsonPath("$.address1").exists())
+                .andExpect(jsonPath("$.address2").exists())
+                .andExpect(jsonPath("$.city").exists())
+                .andExpect(jsonPath("$.contactNumber").exists())
+                .andExpect(jsonPath("$.customerId").value(6))
+                .andExpect(jsonPath("$.name").value("Test Customer"))
+                .andExpect(jsonPath("$.ssn").value("TK01"))
+                .andExpect(jsonPath("$.address1").value("Unit-Test"))
+                .andExpect(jsonPath("$.address2").value("Spring-Boot"))
+                .andExpect(jsonPath("$.city").value("SpringCity"))
+                .andExpect(jsonPath("$.contactNumber").value("9425094255"))
+                .andDo(print());
+    }
+
+    @Test
+    public void ut4_GetCustomerBySsn_InvalidSsn() throws Exception {
+        mockMvc
+                .perform(MockMvcRequestBuilders.get("/v1/customer/AK02").accept(MediaType.APPLICATION_JSON))
+                .andExpect(status().isNotFound())
+                .andExpect(jsonPath("$.apierror.status").value("NOT_FOUND"))
+                .andExpect(jsonPath("$.apierror.message").value("Customer was not found for parameters {ssn=AK02}"))
+                .andDo(print());
+    }
+
+    @Test
+    public void ut5_CreateCustomer_Duplicate() throws Exception {
+        mockMvc
+                .perform(MockMvcRequestBuilders.post("/v1/customer/create")
+                        .contentType(MediaType.APPLICATION_JSON)
+                        .content("{\"name\":\"Test Customer\", \"ssn\":\"TK01\", \"contactNumber\":\"9425094255\",\"address1\":\"Unit-Test\",\"address2\":\"Spring-Boot\",\"city\":\"SpringCity\"}")
+                        .accept(MediaType.APPLICATION_JSON))
+                .andExpect(status().isBadRequest())
+                .andExpect(jsonPath("$.apierror.status").value("BAD_REQUEST"))
+                .andExpect(jsonPath("$.apierror.message").value("Customer was already found for parameters {ssn=TK01}"))
+                .andDo(print());
+    }
+}