Remove incorrect inheritence of external for signals.

SystemRDL · Jan 7, 2025 · f4059a9 · f4059a9
1 parent 686fdb7
commit f4059a9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/systemrdl/__about__.py b/src/systemrdl/__about__.py
@@ -1 +1 @@
-__version__ = "1.29.1"
+__version__ = "1.29.2"
diff --git a/src/systemrdl/core/elaborate.py b/src/systemrdl/core/elaborate.py
@@ -565,12 +565,8 @@ def enter_Field(self, node: FieldNode) -> None:
         node.inst.external = node.parent.inst.external
 
     def enter_Signal(self, node: SignalNode) -> None:
-        if isinstance(node.parent, RootNode):
-            # In root scope. External is meaningless, so assign it to False
-            node.inst.external = False
-        else:
-            assert node.parent is not None
-            node.inst.external = node.parent.inst.external
+        # External is meaningless for signals. Always False
+        node.inst.external = False
 
     def enter_Regfile(self, node: RegfileNode) -> None:
         if self.coerce_external_to is not None: