Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove class data-files-btn #1029

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Dec 3, 2024

Overview

Remove the unnecessary .data-files-btn class.

Details

This class is assigned to buttons that:

  • either have Bootstrap btn-primary class (in which case .workbench-content .btn-primary styles it)
  • or are our custom <Button> (in which case the composes: c-button styles it)

Related

Changes

  • remove assignment of class
  • remove styles for class

Testing

Verify styles of these buttons are unchanged:

  • "Data Files" → [Add +] button
  • "Data Files" → select a file → [Copy]
  • "Allocations" → [Manage Team]

UI

Data.Files.Add.mov
Data.Files.Copy.mov

Allocations Manage Team

Unavailable to me.1

Notes

Footnotes

  1. I am not in a team that I have permission to manage.

This class is assigned to buttons that:
- **either** have Bootstrap btn-primary
    (in which case the `.workbench-content .btn-primary` styles it)
- **or** are our custom `<Button>`
    (in which case the `composes: c-button` styles it)
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.48%. Comparing base (de51694) to head (73e0961).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
- Coverage   72.68%   70.48%   -2.21%     
==========================================
  Files         327      538     +211     
  Lines       27692    33978    +6286     
  Branches     2204     2936     +732     
==========================================
+ Hits        20129    23949    +3820     
- Misses       7525     9829    +2304     
- Partials       38      200     +162     
Flag Coverage Δ
javascript 72.68% <100.00%> (-0.01%) ⬇️
unittests 60.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ataFilesModalTables/DataFilesModalListingTable.jsx 84.46% <100.00%> (ø)
...FilesProjectMembers/_cells/ProjectRoleSelector.jsx 74.02% <ø> (-0.34%) ⬇️
...ts/DataFiles/DataFilesSidebar/DataFilesSidebar.jsx 81.35% <100.00%> (-0.62%) ⬇️

... and 211 files with indirect coverage changes

@chandra-tacc chandra-tacc merged commit 8582dfa into main Jan 9, 2025
5 of 6 checks passed
@chandra-tacc chandra-tacc deleted the chore/remove-data-files-btn branch January 9, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants