Quick: fix impersonation url #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
=======================================
Coverage 63.40% 63.40%
=======================================
Files 432 432
Lines 12403 12404 +1
Branches 2585 2585
=======================================
+ Hits 7864 7865 +1
Misses 4327 4327
Partials 212 212
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chandra-tacc
approved these changes
Nov 16, 2023
rstijerina
force-pushed
the
fix/impersonate-url
branch
from
2981f32 to
95c0767
Compare
jarosenb
approved these changes
Nov 21, 2023
chandra-tacc
pushed a commit
that referenced
this pull request
Dec 8, 2023
* fix impersonation url * explicit impersonate urls; preserve previous impersonate path
chandra-tacc
pushed a commit
that referenced
this pull request
Dec 8, 2023
* fix impersonation url * explicit impersonate urls; preserve previous impersonate path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The django-impersonate middleware was not functioning properly with the url structure we had in place for some reason.
Testing