Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort order to tag entry #362

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add sort order to tag entry #362

wants to merge 13 commits into from

Conversation

TBog
Copy link
Owner

@TBog TBog commented Dec 14, 2022

fix #335

  • long touch on tag entry shows possible result order
  • allow user to choose sort order when adding to Dock
  • check if rename still works after changing sort order
  • add a visual indicator for the currently selected order
  • add debug toggle for displaying TagSortEntry id
  • per-tag history

@Saijin-Naib
Copy link

Could the same "history" based ordering of the Results list be an additional method to A-Z and Z-A sort?

Might feel best to have history per tag vs using global results history so each tag can adapt independently.

@TBog
Copy link
Owner Author

TBog commented Dec 6, 2023

Could the same "history" based ordering of the Results list be an additional method to A-Z and Z-A sort?

You can see in the changes that there are more than those sorting methods
6ec2755#diff-5e01f7d37a66e4ca03deefc205d8e7008661cdd0284a05aaba1858e6b7bf9103R18-R25

I'll update the checklist with per-tag history. But I don't think I understand what the difference is between per tag vs global results history.

@Saijin-Naib
Copy link

Per tag would just consider rank of the items in that tag by how you click on them from that tag.

For instance, if i go to my health/safety manually it is likely for zood or airguard, but in my global, i would hit fitbit more often.

@TBog
Copy link
Owner Author

TBog commented Dec 6, 2023

Per tag would just consider rank of the items in that tag by how you click on them from that tag.

Currently I don't have that information. I just know what the query was when you clicked.

I think it's possible to add the currently displayed tag, I'll have to look into it.

@TBog TBog force-pushed the feature/tag_sort_order branch from d72f412 to 950a053 Compare April 25, 2024 19:06
@TBog TBog force-pushed the feature/tag_sort_order branch from 950a053 to 29fb2f7 Compare May 10, 2024 20:24
@TBog TBog force-pushed the feature/tag_sort_order branch from 29fb2f7 to b704bc7 Compare May 31, 2024 14:39
@TBog TBog force-pushed the feature/tag_sort_order branch from 75acf9f to 8a69b6b Compare May 31, 2024 20:32
@TBog TBog mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort and search within tags
2 participants